MCCodes v2.0.4 Released & Security Doc

**Danny696** · 02-19-2012, 02:04 PM

Originally Posted by Spudinski

So really, the creators of PHP doesn't know better than a random idiot who posted in their comments section?
I don't care if you know a language for 10 or even 20 years, you're an idiot if you go against it's creators.

It was posted on a zend site. Im actually agreeing with your here spud, a php script should have a ?> at the end of the file. You go through the PHP manual, all the examples have ?> at the end, even if its just

Originally Posted by Dabomstew

This discussion on ending tags has drifted away from the point of this topic, so I'll say this: The fact that there is no trailing ?> in the files is controlled by one line of code in our release builder. If you really want a copy of MCCodes v2 with a matching ?> for every <?php, contact us and we'll be happy to provide if you're a customer. Otherwise, it's rather irrelevant.

Dabs, I actually think this is very relevant, were taking about something that is sometimes included, and sometimes excluded, in the McCodes script. If we do reach an agreement, which is very unlikely, as it is mainly personal preference, or just laziness on the developers part, on weather there are benifits or drawbacks of the ?>, then you should include/remove the tag in all files, for the benefit of your paying customers surely?

**Dabomstew** · 02-19-2012, 02:19 PM

Originally Posted by Danny696

Dabs, I actually think this is very relevant, were taking about something that is sometimes included, and sometimes excluded, in the McCodes script. If we do reach an agreement, which is very unlikely, as it is mainly personal preference, or just laziness on the developers part, on weather there are benifits or drawbacks of the ?>, then you should include/remove the tag in all files, for the benefit of your paying customers surely?

Ok, fair enough. To clarify:
Pretty much every php file released by MCCodes until the release of 2.0.4 has had a trailing ?> at the end of every file. Unfortunately, they were also littered with inconsistent code style, different opening tags (<?php vs <?) and a fair amount of trailing whitespace after ?>s.

The new standard, which will be followed from the release of 2.0.4 onwards and for each patch/version following it, will be that there will be no ending ?> where it is unnecessary. This, along with a set of other coding standards to be followed consistently are part of our efforts to improve the understandability of the MCC scripts.

It is true that whether MCCodes scripts should have ?> or not is a valid talking point, but the war of whether it is "better" to have them or not from a standpoint of best practice appears to not have a clear winner. It is this part which is getting offtopic, not how it applies to MCCodes.

**Spudinski** · 02-19-2012, 02:41 PM

Originally Posted by Dabomstew

It is true that whether MCCodes scripts should have ?> or not is a valid talking point, but the war of whether it is "better" to have them or not from a standpoint of best practice appears to not have a clear winner. It is this part which is getting offtopic, not how it applies to MCCodes.

There is a clear winner. But that's not what we're discussing.
We're talking about the benefits between having, and not having a closing tag present.
But, kudos for following a coding style.

@Danny, I'm not biased. Though I prefer to use closing tags, I don't see why it's needed or not needed.
It's down to preference in my eyes, nothing else. Except of course other technical sides of it, as mentioned before.

**mr moon** · 02-19-2012, 09:53 PM

Well i understand that Mccodes Developers have put up an downloadable copy of the secured/bug fixed etc. version, well 1 thing i do not like is the text file as Mccodes have not put an fix, they just tell us what to do and i honestly dont understand what they are trying to say etc. as i am not that experienced so would it not be better if Mccodes could have actually put the fix instead of telling us how to fix it or even tell us both. Thanks

**Nickson** · 02-20-2012, 12:09 AM

Originally Posted by mr moon

Well i understand that Mccodes Developers have put up an downloadable copy of the secured/bug fixed etc. version, well 1 thing i do not like is the text file as Mccodes have not put an fix, they just tell us what to do and i honestly don't understand what they are trying to say etc. as i am not that experienced so would it not be better if Mccodes could have actually put the fix instead of telling us how to fix it or even tell us both. Thanks

Well in all honesty, they can't do much more than that. They have made a v2.0.4 available from the client area so you can download it, and replace all old files. As other option they have provided a document on how to upgrade manually from v2.0.3 to v2.0.4. I don't think they can do much more since, if you have touched the code, a replacement is void, and they can never know what you have edited in what way to make the upgrade happen. With a good document - I don't know how it looks like though - any game owner should be able to upgrade his codes if preferred. If you can't do this, then I'm afraid that the fault is with you. You can always contact them and ask whether they want to do the upgrade for you freely, but I don't think that will happen either.

**mr moon** · 02-20-2012, 12:49 AM

Yes this is what i am talking about the manually upgrade i dont have no game running up or anything but i dont like how it is it tells does not give any examples of like it only tells what to do such as it gives link of a website of what to do and an example of the forum fix they gave is this

Fix:
Sanitize the st value to be a positive integer.

what the heck do i do. i aint experienced programeer then i dont understand what that meant but it they gave a real example like how the proper fix should look like that would have been better.

So basicly imagine i make a game with the Mccodes V2.4 then after 6 months theres a new upgrade well ill have to manually do it but if i dont understand it then how will i update my copy.

Mccodes owners take into account that not everyone understands what your trying to say so it would be better if you explained in more detail and give a example of the fix so we get an idea on how it works.

And Nickinson what you on about? my message above was about manually upgrade but half of the stuff you are saying is about something else.

**Dabomstew** · 02-20-2012, 01:05 AM

Manually upgrading a 2.0.3 game to include EVERYTHING in 2.0.4 would be a very long-winded, almost impossible process as the actual code changes number in the hundreds, if not over a thousand.

However, we will update the security document within the next few days to include specific fixes for the specific problems listed.

**mr moon** · 02-20-2012, 01:40 AM

Originally Posted by Dabomstew

Manually upgrading a 2.0.3 game to include EVERYTHING in 2.0.4 would be a very long-winded, almost impossible process as the actual code changes number in the hundreds, if not over a thousand.

Did not ask for that LOL. i asked for a detailed and easy to understand an few examples to get me an idea of how its works, i did not ask for the whole fix like 1 by 1 on the manual (but that would be nice) but i asked for an few examples to get an idea on what to do.

Thank you that would be great and please make it detailed and easy to understand and examples would be great of the actual fix like 2,3 or even 4 or 5, examples out of 100 would be nice so we would get an idea on fixing the other 95 etc.

Thanks
Mr Moon

**HauntedDawg** · 02-20-2012, 07:13 AM

No offense here, but did not read through all the post's, just scoped through them.

Making one fix to the hall of fame does not mean now it is completely fixed.

Did you perhaps think of browsing on here for actual fixes first?

Hall of Fame - [bug] fix Crystals in Hall of Fame http://www.makewebgames.com/showthre...n-version-2-03

That is not the only issue with the hall of fame.

Could simply just use: http://www.makewebgames.com/showthre...fame-COMPLETED!

Another issue..

[bug] fix possible Battle Tent infinite loop

Again simply use: http://www.makewebgames.com/showthre...Battletent-Fix

But then again, its a plus to releasing some changes.

**Dabomstew** · 02-20-2012, 07:22 AM

Originally Posted by HauntedDawg

No offense here, but did not read through all the post's, just scoped through them.

Making one fix to the hall of fame does not mean now it is completely fixed.

Did you perhaps think of browsing on here for actual fixes first?

Hall of Fame - [bug] fix Crystals in Hall of Fame http://www.makewebgames.com/showthre...n-version-2-03

That is not the only issue with the hall of fame.

Could simply just use: http://www.makewebgames.com/showthre...fame-COMPLETED!

Another issue..

[bug] fix possible Battle Tent infinite loop

Again simply use: http://www.makewebgames.com/showthre...Battletent-Fix

But then again, its a plus to releasing some changes.

Thanks for the feedback, but this *was* primarily a bugfix release and so the focus was on fixing what was there to do what was intended, not improve it.

There were some improvements made, as you can see in the changelog, but they were mostly either very important things or byproducts of the bugfixing process.

We will consider stuff like "improved" mods being integrated if there is another patch release, but there are also licensing issues associated with that even if the mods are released as "free".

To the best of our knowledge we have fixed the bugs found in v2.03.